fix: remove no-op clearCache and fix cachedAt typing in claimable service#605
Open
wheval wants to merge 1 commit into
Open
fix: remove no-op clearCache and fix cachedAt typing in claimable service#605wheval wants to merge 1 commit into
wheval wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Removes the misleading no-op
clearCache()method fromClaimableAmountServiceand fixes the type hole on cache-hit responses by declaringcachedAtonClaimableAmountResult.🎯 Purpose / Motivation
clearCache()was exported but did nothing, which could mislead callers into thinking cached claimable values were being invalidated. On cache hits, the service returned{ ...cachedEntry, cached: true, cachedAt } as any, bypassing TypeScript becausecachedAtwas not part of the declared result type.🛠️ Changes Made
clearCache()method (no callers in the codebase).cachedAt?: stringtoClaimableAmountResultso cache-hit metadata is typed correctly.as anycast on the cache-hit return path.🧪 How to Test
backend/, runnpm test -- claimable.service.test.ts.uses cache for repeated request with same stream state + timestamp).getClaimableAmounttwice with the same input and verify the second response hascached: trueand an ISOcachedAtstring when served from cache.clearCache()had no references;cachedAtremains optional on responses.🔗 Related Issues
Closes #547
✅ Checklist