chore: untrack 5 snapshot JSONs re-committed after 46a731f#592
Open
K1NGD4VID wants to merge 7 commits into
Open
chore: untrack 5 snapshot JSONs re-committed after 46a731f#592K1NGD4VID wants to merge 7 commits into
K1NGD4VID wants to merge 7 commits into
Conversation
These files were removed from tracking in 46a731f (chore: remove test_snapshots from tracking, add to .gitignore) but were re-committed in subsequent feature branches without being caught by the ignore rule. The policy is clear: test_snapshots/ is auto-generated by the Soroban test runner and must never be committed. No .gitignore changes needed.
vitest.config.ts sets coverage.provider = 'v8', which requires @vitest/coverage-v8 as a peer. It was missing from devDependencies, causing CI to fail with MISSING DEPENDENCY on npm test.
Contributor
|
hey, #706 just merged and fixes a broken test-mock pattern that was causing 'Failed Suites' / 'is not a function' / '0 tests' on backend integration tests. please rebase to pick it up: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
…tion/purity/effect rules
Author
|
please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files were removed from tracking in 46a731f (chore: remove test_snapshots from tracking, add to .gitignore) but were re-committed in subsequent feature branches without being caught by the ignore rule.
The policy is clear: test_snapshots/ is auto-generated by the Soroban test runner and must never be committed. No .gitignore changes needed. closes #584