fix: add macOS version check for base64 argument compatibility #127
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
Y
N
fix Update install-kusion.sh for OS X Tahoe base64 change #126
2. What is the scope of this PR (e.g. component or file name):
scripts/install-kusion.sh3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Install script uses
base64to encode kubeconfig key. Thebase64args changed in the latest OS X (Tahoe)4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
bash install-kusion.sh kubeconfig_key1=/path/to/keyworks in latest OS X
6. Release note
The fix addresses compatibility issues where the base64 command parameters differ between operating systems and macOS versions. This ensures the Kusion Helm chart installation works correctly regardless of the platform.
Fixed base64 encoding on macOS: Updated the install script to properly handle base64 encoding across different macOS versions
base64 -w 0 -ibase64 -b 0 -ibase64 -w 0Enhanced cross-platform support: The script now automatically detects the operating system and applies the correct base64 parameters
Files Changed:
scripts/install-kusion.sh: Updated base64 encoding logic for cross-platform compatibility