Add documentation and tests for the last and lastOrNull functions
#1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allex-Nik
requested review from
AndreiKingsley,
Jolanrensen,
koperagen and
zaleslaw
Collaborator
Author
|
The checks fail for now because in the documentation I refer to |
Allex-Nik
commented
Nov 12, 2025
Allex-Nik
commented
Nov 12, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/last.kt
Outdated
Show resolved
Hide resolved
Collaborator
I expect it to be merged soon. If it takes too long, you can also copy the code from #1554 and let git handle the merge. Whatever you like best :) |
Jolanrensen
reviewed
Nov 13, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/last.kt
Outdated
Show resolved
Hide resolved
Allex-Nik
force-pushed
the
last-lastOrNull-documentation-tests
branch
3 times, most recently
from
317b0a0 to
54d7873
Compare
Allex-Nik
force-pushed
the
last-lastOrNull-documentation-tests
branch
from
54d7873 to
742b751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1497