Skip to content

.auth doesn't work together with .attach #80 fix#109

Open
beshanoe wants to merge 1 commit into
Kong:masterfrom
beshanoe:really-fix-issue-80
Open

.auth doesn't work together with .attach #80 fix#109
beshanoe wants to merge 1 commit into
Kong:masterfrom
beshanoe:really-fix-issue-80

Conversation

@beshanoe

@beshanoe beshanoe commented Jun 16, 2017

Copy link
Copy Markdown

Fix for #80
The previous try didn't fix it fully #86
When use Request.auth(username, password, sendImmediately) notation, it was creating incorrect auth object, it was using 'password' instead of 'path'

@nijikokun

nijikokun commented Jun 16, 2017

Copy link
Copy Markdown
Contributor

Mind adding a test for the case? This way we know that it's working as intended going forward 👍

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mvalenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants