Skip to content

Conversation

rspurgeon
Copy link
Collaborator

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 13:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "adopt" command feature that allows users to apply namespace labels to existing Konnect resources, enabling them to bring previously unmanaged assets under kongctl management.

  • Introduces the adopt verb and command structure for managing namespace labels on existing resources
  • Implements adoption functionality for four resource types: portals, control planes, APIs, and auth strategies
  • Adds comprehensive test coverage including end-to-end test scenario infrastructure with HTTP resource creation capabilities

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/e2e/scenarios/adopt/create-portal-adopt-dump-apply/scenario.yaml End-to-end test scenario validating the adopt workflow
test/e2e/harness/step.go Test harness enhancements for HTTP resource creation and environment handling
test/e2e/harness/scenario/types.go Test scenario type definitions for create operations and variable recording
test/e2e/harness/scenario/run.go Test scenario execution logic with create command support and output handling
test/e2e/harness/cli.go CLI test harness improvements for output format control and command capture
internal/cmd/root/verbs/verbs.go Adds the Adopt verb constant
internal/cmd/root/verbs/adopt/direct.go Direct adopt command implementations for all resource types
internal/cmd/root/verbs/adopt/adopt.go Main adopt command structure and subcommand registration
internal/cmd/root/root.go Registers the adopt command in the root CLI
internal/cmd/root/products/konnect/*.go Updates existing resource command handlers to support the adopt verb
internal/cmd/root/products/konnect/adopt/*.go Core adopt implementation with resource-specific logic and comprehensive tests
docs/declarative-configuration.md Documentation for the new adopt command usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant