Skip to content

Conversation

@harshadixit12
Copy link
Contributor

@harshadixit12 harshadixit12 commented Nov 17, 2025

Summary

Risks

  1. No schema given for a field
  2. Performance - the new implementation for comparing plugin equality is expected to be slower - by how much?
  3. Is diff shown on console accurate on deck?
  4. Integration tests for some plugins?

SUMMARY_GOES_HERE

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@harshadixit12
Copy link
Contributor Author

harshadixit12 commented Nov 18, 2025

Performance impact of sorting based on schema - negligible (<3s increase for 13,900 entities).
config - about 1400 plugins, total 13900 entities, with parallelism 1 (significantly lesser in normal parallelism)
Screenshot 2025-11-18 at 1 40 23 PM
Screenshot 2025-11-18 at 1 45 50 PM

@harshadixit12 harshadixit12 force-pushed the fix/no-diff-request-transformer-plugin branch from 9c22adf to 23c0114 Compare November 18, 2025 12:35
return false
}

typeStr := typeResult.String()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can combine this and line 704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants