If sortInfo is passed in, sort by that column initially#304
Open
bdukes wants to merge 1 commit intoKnockout-Contrib:masterfrom
Open
If sortInfo is passed in, sort by that column initially#304bdukes wants to merge 1 commit intoKnockout-Contrib:masterfrom
bdukes wants to merge 1 commit intoKnockout-Contrib:masterfrom
Conversation
|
👍, though something tells me this project is dead and this will never get done. |
Member
|
@kohenkatz Please check the milestones and see how you may help in moving forward. The progress is slow but hopefully the number of contributors will grow. Any help you can provide is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the documentation, passing
sortInfoin the options should set the default sorting state. However, nothing is looking at the value that is initially passed in.This patch looks to see if the
sortInfohas afield, when the grid is initialized. If so, it calls thesortmethod of that column. However, this sets the column direction, but the sorting is overwritten later during some other initialization. To combat that, I've wrapped thesortcall in asetTimeout.This fixes #244 and #74