Move legacy project relationship methods to project service #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is only used in a single controller.
williamjallen
force-pushed
the
project-service
branch
from
fee97de to
1ff4d32
Compare
josephsnyder
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, models provided helper methods to access relationships for specific needs. Custom helpers like this are an antipattern in active record systems like Eloquent, so it doesn't make sense to simply move these helpers over to our Eloquent models. Instead, it's traditional for services to fill this role. As such, this PR moves the methods which only depend on a model's project ID to the
ProjectServiceclass. With much of the business logic in the legacyProjectmodel out of the way, this should enable us to migrate away from the legacy model more quickly.