Skip to content

Address yamux transport review findings#46

Merged
Kirari04 merged 1 commit into
devfrom
docs/yamux-merge-final-ledger
Jun 6, 2026
Merged

Address yamux transport review findings#46
Kirari04 merged 1 commit into
devfrom
docs/yamux-merge-final-ledger

Conversation

@Kirari04

@Kirari04 Kirari04 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removes the public docs/.plans handoff ledger and ignores docs/.plans/ going forward.
  • Addresses the valid CodeRabbit findings from PR Merge yamux agent transport rewrite #45:
    • tunnel DB/hub registration now happens after the Yamux session is established,
    • tunnel version strings use tunnel.ProtocolVersion,
    • agent tunnel bootstrap has a bounded response-header timeout,
    • agent transport pool invalidation happens before refresh can fail,
    • dialViaAgent handles cancellation during stream open/open handshake,
    • test/smoke resource leaks and brittle assertions are fixed,
    • make kill no longer hard-fails without ss.

Validation

  • git diff --check
  • go test ./internal/server -run 'TestRotateAgentTokenClosesTunnelConnection|TestAgentTunnelRejectsDuplicateConnection|TestAgentTransportPool|TestAgentProxy|TestPublicBackendHealth'
  • go test ./internal/agent
  • go test -tags docker_smoke -run '^$' ./internal/smoketest ./internal/smoketest/upstream
  • go test ./...
  • go vet ./...
  • bun run --cwd web/management typecheck

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Kirari04, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 18 minutes and 46 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 91f688f2-1a26-4a12-9f52-6288a0256a2c

📥 Commits

Reviewing files that changed from the base of the PR and between 3d67338 and ab864de.

📒 Files selected for processing (11)
  • .gitignore
  • Makefile
  • agent_tunnel_test.go
  • docs/.plans/agent-yamux-overhaul.md
  • internal/agent/agent.go
  • internal/server/agent_registry.go
  • internal/server/public_backend_health_test.go
  • internal/server/public_routing.go
  • internal/server/server.go
  • internal/smoketest/docker_smoke_test.go
  • internal/smoketest/upstream/main.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/yamux-merge-final-ledger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kirari04 Kirari04 force-pushed the docs/yamux-merge-final-ledger branch from c4d76fa to ab864de Compare June 6, 2026 17:58
@Kirari04 Kirari04 changed the title Finalize yamux merge ledger Address yamux transport review findings Jun 6, 2026
@Kirari04 Kirari04 merged commit 65f588e into dev Jun 6, 2026
8 checks passed
@Kirari04 Kirari04 deleted the docs/yamux-merge-final-ledger branch June 6, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant