Fix of calculation of qpar for run time diagnostic - #365
Closed
mrhardman wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This looks like the right test. Hopefully this fix makes #363 consistent! 🤞 |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stub PR to demonstrate that fixing the calculation of
qparin run-time diagnostics for 2V requires us to update the tests in #363. We do not need to merge this PR if tests pass, instead, we should update #363. The calculation ofqparhere is not optimal in 2V cases because a copy offfis made before every call toget_qpar().