Convert 'anyv' parallelisation to 'anysv' - #361
Merged
Conversation
Collaborator
Author
|
@mrhardman for now this PR does not include any loops over species, and just hard-codes |
9 tasks
Anticipate that when calculating multi-species collisions, the collision operators for every species should be calculated together, to be able to re-use parts of the computation. Therefore rather than 'anyv' regions inside an outer loop over species, r, and z, we want to have an outer loop over r and z, containing inner loops over both species and velocity space - call this an 'anysv' region (for any 's'pecies or 'v'elocity).
Currently only supports a single ion species - `is = 1` is hard-coded in the outer loop.
johnomotani
force-pushed
the
anysv-region
branch
from
July 13, 2025 15:52
7cac207 to
0c07882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anticipate that when calculating multi-species collisions, the collision operators for every species should be calculated together, to be able to re-use parts of the computation. Therefore rather than 'anyv' regions inside an outer loop over species, r, and z, we want to have an outer loop over r and z, containing inner loops over both species and velocity space - call this an 'anysv' region (for any 's'pecies or 'v'elocity).
Resolves #356.