[WIP] Swap serial lu for MPI parallel qr using MPIQR.jl#307
Open
jwscook wants to merge 16 commits into
Open
Conversation
… how it was before
Author
|
Right now |
added 6 commits
January 21, 2025 13:53
Collaborator
|
In case someone else wants to try this gave me a prompt asking for a private key to access Github, but just repeated the prompt when I gave it the key. Using instead just worked. |
Author
|
LU decomposition is able to exploit sparsity whereas QR decomposition is not. This means there's a huge performance gap between the two approaches. An example matrix has 2% non-zeros, hence a dense method is not going to win-out. For reference, and thanks to @johnomotani: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
luserial solve and replaces it with an MPI block-parallel QR decomposition viaMPIQR.jl. This PR only changes the code relevant to the actual solve, not the code for configuration. This means the rest of the code still referes to thelusolve, when in fact it will performing aqrsolve.