Bisection for get_ielement(), checks on reference grids#6
Merged
Conversation
…ger values of nelement. Leave original implementation in comments.
…1 and 1, respectively, to make sure that the continuous Galerkin method can use an assembly for the global grid and operators of the type implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a bisection algorithm rather than a brute force linear search for
get_ielement(), which finds the element index given a coordinate value.Reduce tolerances to
eps(Float64)from ad-hoc values.Ensure that
FiniteElementCoordinategrids in general use collocation points in reference coordinates that include the internal boundary points-1and1where appropriate.