Skip to content

FIM prompt without XML parsing #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

FIM prompt without XML parsing #3400

wants to merge 13 commits into from

Conversation

@beatlevic
Copy link
Collaborator

WiP moving from search/replace XML LLM responses to more simple FIM (Fill in the middle).

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8fce523

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

markijbema
markijbema approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test extensively; but this looks like a great improvement

markijbema
markijbema approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do merge if you trust it enough

@beatlevic beatlevic marked this pull request as ready for review October 30, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markijbema markijbema markijbema approved these changes

@brianc brianc Awaiting requested review from brianc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beatlevic @markijbema