Repository navigation
Conversation
| url: https://github.com/ClickHouse/loom | ||
| category: data | ||
| prerequisites: | ||
| - "A running Loom server. On one machine: curl -fsSL https://github.com/ClickHouse/loom/releases/latest/download/install.sh -o loom-install.sh && sh loom-install.sh (Docker)" |
There was a problem hiding this comment.
SUGGESTION: Pin the installer and declare Docker explicitly
This prerequisite tells users to download install.sh from releases/latest and run it with sh with no version pin and no checksum, so the exact code executed can change at any time and cannot be verified. It also depends on Docker, but Docker is only mentioned in parentheses rather than declared as a prerequisite, so installs on machines without Docker fail opaquely.
Minimal fix: reference a pinned release (or a published checksum) and add Docker as its own prerequisite entry, e.g. - Docker (the one-line installer runs Loom in a container).
There was a problem hiding this comment.
Done in 729e7dc: Docker with the Compose v2 plugin (2.20 or later, which the installer checks) is now its own prerequisite, and the command points at the versioned installer releases/download/v1.2.0/install.sh. Loom publishes no checksum for install.sh itself; the installer verifies the stack bundle it downloads against the release's loom-stack.tar.gz.sha256, and the prerequisite says so.
| } | ||
| } | ||
| parameters: | ||
| - name: Loom server URL |
There was a problem hiding this comment.
SUGGESTION: Clarify that this must be the server origin without a trailing slash
The value is concatenated as {{LOOM_URL}}/mcp?toolset=coding, so an origin entered with a trailing slash (https://loom.example.com/) or with a path yields //mcp or a duplicated path and the connection fails. Naming the parameter for the expected form avoids that.
| - name: Loom server URL | |
| - name: Loom base URL (origin only, no trailing slash or path) |
There was a problem hiding this comment.
Done in 729e7dc: the parameter is now "Loom base URL (origin only, no trailing slash or path)", as suggested. mcps/marketplace.yaml is regenerated; pnpm test and pnpm run typecheck:mcps pass.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Verification notes: Incremental review of Not verifiable offline (unchanged from the prior review): that Previous Review Summaries (2 snapshots, latest commit 729e7dc)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 729e7dc)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Verification notes: Incremental review of Not verifiable offline: that Previous review (commit 77e7e67)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Verification notes: id/directory agreement ( Reviewed by deepseek-v4.1-flash-1017 · Input: 53.9K · Output: 20.5K · Cached: 990.6K Review guidance: REVIEW.md from base branch |
|
@alaapmurali a gentle ping on this one when you have a moment. Happy to change the wording, section or placement if you'd prefer. Thanks! |
|
Could a maintainer review this ClickHouse Loom MCP marketplace entry? Are any changes or additional information needed? |
Use the released 1.3.0 installer and canonical setup guide while preserving the existing local and authenticated team connection configurations. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Adds ClickHouse Loom's self-hosted MCP entry and generated catalog entry. Loom provides shared agent memory, document search and a repository code index. I work on Loom; Codex assisted with this update.
The prerequisites link the published quickstart and pin the installer to release 1.3.0. Install the server before adding the entry. The default local endpoint is loopback-only; team access requires your own reachable deployment and a scoped bearer token. The entry's transport, endpoint templates and token placeholders are unchanged.
Two installation options remain:
http://localhost:7777/mcp?toolset=coding.{{LOOM_URL}}/mcp?toolset=codingwith theLOOM_API_KEYbearer parameter. Credentials are supplied by the user, never embedded in the catalog.Validation for this update:
Only
mcps/clickhouse-loom/MCP.yamland its generated entry inmcps/marketplace.yamlchange. No shared hosted service, default marketplace inclusion or performance result is claimed.