Repository navigation
Add Screwtape.ai MCP server - #672
screwtapeai wants to merge 2 commits into
Conversation
| parameters: | ||
| - name: Screwtape API key | ||
| key: SCREWTAPE_API_KEY | ||
| placeholder: your_screwtape_api_key |
There was a problem hiding this comment.
WARNING: Optional API key is declared as required
The prerequisite on line 8 describes the Bearer API key as optional (keyless Remote MCP still works with 3 calls/day), but this parameter is not marked optional: true. CONTRIBUTING.md:448-459 documents optional: true for optional parameters, and comparable entries such as mcps/neon/MCP.yaml use it for an optional API key. Without the flag, clients that treat non-optional parameters as required can block the keyless install path this entry advertises.
Minimal fix: add optional: true to this parameter.
| "Authorization": "Bearer {{SCREWTAPE_API_KEY}}" | ||
| } | ||
| } | ||
| parameters: |
There was a problem hiding this comment.
SUGGESTION: Duplicate parameter definition
SCREWTAPE_API_KEY is declared here (content-level) and again in the top-level parameters block at lines 29-32 with identical name/key/placeholder. Existing entries use content-level parameters only for variant-specific keys (e.g. mcps/apify/MCP.yaml ACTOR_LIST, mcps/e2b/MCP.yaml E2B_PATH). Duplicating the same key in both lists risks the client showing the prompt twice or letting the two definitions drift.
Minimal fix: drop this content-level block and keep the single top-level definition (or drop the top-level one).
Code Review SummaryStatus: No Issues Found | Recommendation: Merge What changed since the previous reviewBoth prior findings are resolved at
Files Reviewed (2 files)
Verification notes
Previous Review Summary (commit cfd29f6)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit cfd29f6)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (2 files)
Verification notes
Reviewed by deepseek-v4.1-flash-1017 · Input: 96.8K · Output: 9.1K · Cached: 757.3K Review guidance: REVIEW.md from base branch |
|
Addressed both review notes: |
Agent buy (x402 LIVE)curl -sS https://screwtape.ai/pricing.json
curl -sS -X POST https://screwtape.ai/v1/packages/metered_spend_clearance/buy # $29 / 5k clearances
curl -sS -X POST https://screwtape.ai/v1/packages/agent_fleet_compliance/buy # $19 / 1k trust-scoreSettle 402 with |
Adds the official Screwtape.ai remote MCP server.
Regenerated mcps/marketplace.yaml. Ran
pnpm exec tsx generate-mcps-marketplace.ts,pnpm test, andpnpm run typecheck:mcpsin bin/ (119 tests passed).