Add tabIndex as a prop to PhosphorIcon#2573
Open
kevinb-khan wants to merge 4 commits into
Open
Conversation
… change updates the types to reflect that
🦋 Changeset detectedLatest commit: 42821e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Contributor
|
Size Change: 0 B Total Size: 89.2 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (2c8fa11) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2573"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2573 |
jandrade
approved these changes
Apr 29, 2025
jandrade
left a comment
jandrade
left a comment
Member
There was a problem hiding this comment.
Looks great! thanks for the quick fix 🚢
beaesguerra
approved these changes
Apr 29, 2025
beaesguerra
left a comment
beaesguerra
left a comment
Member
There was a problem hiding this comment.
Thanks for noticing this and fixing this! 🚀
Member
|
@kevinb-khan just checking if we want to land this fix? I can commandeer it if you think it makes sense :) |
Contributor
Author
|
@jandrade commandeering would be very much appreciated. 😅 |
Contributor
Author
|
@jandrade I've assigned this PR to you. Thanks for taking this over for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PhosphorIcon already support the tabIndex prop, this change updates the types to reflect that.
Issue: XXX-XXXX
Test plan: