Encode Zcash device version in account exports - #134
Merged
soralit merged 4 commits intoJul 23, 2026
Conversation
czarcas7ic
marked this pull request as ready for review
July 22, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode the optional Zcash device firmware version as CBOR map key 3 so account-sync wallets receive the value already supplied by firmware. Exports without a device version retain the existing two-field encoding, while the decoder remains compatible with both forms.
The branch also incorporates Keystone's existing 1.0.7 version commits so downstream patches can retain the released crate requirements while testing this fix.
Validated with the complete workspace test suite plus focused registry, FFI, and UR round-trip tests.