[codex] update latest stable deps and ci#51
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s pinned toolchain/dependencies and CI/container infrastructure to track the latest stable Go patch releases and refreshed workflow/image digests, and adjusts the container’s Paper “latest” resolution to prefer stable releases.
Changes:
- Bump Go toolchain/module patch versions and refresh Go dependency metadata (
go.mod/go.sum). - Refresh pinned GitHub Actions SHAs across CI/container/nightly workflows.
- Update container base image digests and adjust Paper “latest” selection logic in the container build to avoid RC/previews; sync contributor/user docs accordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates documented preferred/minimum Go versions to match the bumped toolchain. |
| CONTRIBUTING.md | Syncs contributor prerequisites table and Codespaces note to new Go versions. |
| go.mod | Bumps go + toolchain patch versions and updates a few dependency versions. |
| go.sum | Refreshes sums to align with the updated module versions. |
| internal/console/commands_test.go | Normalizes formatting by removing a stray trailing line. |
| Containerfile | Updates base image digests and changes how MC_VERSION=latest resolves Paper to prefer stable versions. |
| .github/workflows/nightly.yml | Refreshes pinned action SHAs (checkout, goreleaser action). |
| .github/workflows/container.yml | Refreshes pinned action SHAs for build/push, metadata, login, QEMU/Buildx, and SARIF upload. |
| .github/workflows/ci.yml | Refreshes pinned action SHAs and updates Go version matrix to the new patch levels. |
Comment on lines
101
to
+105
| if [ "$MC_VER" = "latest" ] || [ -z "$MC_VER" ]; then \ | ||
| MC_VER=$(curl -fsSL -H "User-Agent: ${UA}" \ | ||
| "https://fill.papermc.io/v3/projects/paper/versions" \ | ||
| | jq -r '.versions[0].version.id'); \ | ||
| | jq -r '[.versions[].version.id | select(test("^[0-9]+(\\.[0-9]+){1,2}$"))][0]'); \ | ||
| [ -n "$MC_VER" ] && [ "$MC_VER" != "null" ] || \ |
Contributor
There was a problem hiding this comment.
Implemented in 872bf01: the CLI paperLatestVersion path now skips RC/pre-release IDs and selects the newest stable version, matching the container behavior. I also added tests covering an RC-first versions list and the no-stable-version error case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latestresolve to the newest stable release instead of RCsgofumptformatting issue ininternal/console/commands_test.goWhy
The repo was slightly behind on stable Go patch levels, workflow pins, and container base digests. During validation, the container build also exposed that Paper's API now returns a release candidate ahead of the stable line for
latest, which broke bundled plugin startup during the image warmup boot. This change keeps the repo current while preserving the existing dual-Go support model and makes container builds prefer stable Paper releases.Validation
go mod tidygo build ./cmd/mc-dad-server/go test -race ./...go vet ./...go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.4 rundocker build -f Containerfile -t mc-dad-server:test .Notes
The container image now builds successfully against the stable Paper line (
26.1.2at validation time) instead of incorrectly selecting26.2-rc-2. AppCDS warmup still falls back without producing the archive in this environment, but the build completes and the RC-related plugin startup regression is resolved.