Implement treeSubtree; fix websocket stream setup and auto() stdout logging#11
Merged
Merged
Conversation
unp1
force-pushed
the
fix/server-protocol
branch
from
June 22, 2026 17:59
3b92fd7 to
0bbf355
Compare
unp1
force-pushed
the
fix/server-protocol
branch
from
June 22, 2026 18:53
0bbf355 to
d181b5f
Compare
wadoon
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server protocol/behavior fixes (
keyext.api):treeSubtreewas a silent stub returning an empty list. It is now implemented: it locates the node by serial number and returns the subtree rooted at it (the node followed by its descendants, pre-order), or an empty list if the node is unknown.--websocketmode never calledestablishStreams(), so the launcher was handednullinput/output. It now sets up the streams like the other modes.auto()wrote"Starting proof with setting …"to stdout, corrupting the JSON-RPC channel in--stdmode. It now logs at debug level via slf4j.Tests:
TreeSubtreeTestcovers #12 (fails on the old stub). #14 (needs a websocket peer) and #15 (stdout hygiene) are verified by inspection rather than a dedicated unit test.Stacked on #7; retarget to
mainonce it merges. TouchesKeyApiImplin different methods than #6/#10, so they merge cleanly.PR has been created with AI tooling