Skip to content

Implement submission rules. Be stricter with status at time limit - #496

Merged
pehrsoderman merged 3 commits into
Kattis:masterfrom
gkreitz:445_improve_error_for_submissions
Oct 8, 2026
Merged

pehrsoderman merged 3 commits into
Kattis:masterfrom
gkreitz:445_improve_error_for_submissions

Conversation

@gkreitz

@gkreitz gkreitz commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

This PR starts implementing the infrastructure we need to support submissions.yaml - in particular we add the permitted and score rules (globally scoped).

We use these in legacy, and replace many of the submission checks with these new rules.

Functional changes:

  • Getting the incorrect verdict at time limit (but correct verdict at the safety margin) is now an error. Earlier, this was just a warning.
  • Getting incorrect status on a test case is now a warning (but it's only an error if the final verdict ends up wrong)
  • The messages omit the test case with the worst CPU time when not relevant (to avoid confusing users as to what test case was problematic).

Fixes #445

…us at time limit be an ERROR

This PR starts implementing rules for submission outcomes (to
eventually support submissions.yaml). Here, we implement the
`permitted` and `score` rules, and use them in legacy to
replace our hand-built rules for submission checks.

Earlier, having the submission status be incorrect at the time
limit, but ok at the safety margin was just a warning. I don't
see how we can support this cleanly going forward, so now, an
incorrect status at the time limit is an error.
@pehrsoderman
pehrsoderman merged commit 7d55d5a into Kattis:master Oct 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slightly confusing error on WA

2 participants