Run tests against Ruby 3.3

[jturel]

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d95151c7-9026-4652-8883-c1933b7c2627

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ofedoren]

Thanks, @jturel, it's nice to see green CI here without any changes needed :) Although, CI might not catch all :/

Anyway, I only have one concern: we need to run on both Ruby 3.0 and Ruby 3.3. The Set became part of standard lib in Ruby 3.2 only, so 3.0 still requires us to explicitly require 'set' . Even though it seems fine, I'd rather be paranoid and add those statements where we actually call Set.new (app/services/katello/product_content_finder.rb#L29, app/services/katello/registration_manager.rb#L71) or maybe include it somewhere else, so we require it before it gets used.

[ofedoren]

Not related to this PR, but that's weird. Is .gem. really needed? All the other gemspecs have s.required_ruby_version...

[sjha4]

Pretty sure we don't need the gemspec at all since bastion is now loaded as an engine and we don't build it as a gem..

[ofedoren]

Or, since those are not necessary changes, we can leave those statements (they are harmless), but add TODO comment, something like Drop when Ruby 3.2 is the new minimum.

[sjha4]

I have borrowed the commits from this PR and added a small change to remove the bastion gemspec which is legacy code in this PR here: #11778. Thanks @jturel , @ofedoren .. ❤️