Fixes #39367 - prevent global override of CSS#11765
Open
MariaAga wants to merge 1 commit into
Open
Conversation
|
Warning Review limit reached
More reviews will be available in 17 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
📝 WalkthroughWalkthroughThis PR updates SCSS stylesheets across 24 component and page-level files to apply OUIA component-id attribute selectors for scoping, modernize CSS property syntax (overflow-wrap, gap, ::after), refine selector specificity through nesting, and clean up whitespace formatting. ChangesSCSS Component Scoping and Modernization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MariaAga
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webpack/scenes/RedHatRepositories/index.scss`:
- Around line 5-7: The .row-eq-height rule contains an invalid display value and
a duplicate; remove the line with "display: flexbox" (invalid) and keep only a
single "display: flex" declaration in the .row-eq-height selector so the rule
has one valid display property; update the SCSS where the .row-eq-height block
is defined (look for the .row-eq-height selector) to remove the extra/invalid
lines.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b7a53d8c-e9e1-4706-a0b3-cf525b5c3bbc
📒 Files selected for processing (25)
webpack/ForemanColumnExtensions/index.scsswebpack/components/Bookmark/Bookmark.scsswebpack/components/OptionTooltip/OptionTooltip.scsswebpack/components/RoutedTabs/RoutedTabs.scsswebpack/components/Table/MainTable.scsswebpack/components/TooltipButton/TooltipButton.scsswebpack/components/extensions/HostDetails/Cards/ContentViewDetailsCard/ContentViewDetailsCard.scsswebpack/components/extensions/HostDetails/Cards/ContentViewDetailsCard/_shared-assignment-styles.scsswebpack/components/extensions/HostDetails/Cards/ErrataOverviewCard.scsswebpack/components/extensions/HostDetails/Cards/HostCollectionsCard/HostCollectionsCard.scsswebpack/components/extensions/HostDetails/Cards/SystemPurposeCard/SystemPurposeCard.scsswebpack/components/extensions/HostDetails/Tabs/ErrataTab/ErrataTab.scsswebpack/components/extensions/HostDetails/Tabs/TracesTab/EnableTracerModal.scsswebpack/containers/Application/overrides.scsswebpack/scenes/ContainerImages/Synced/SyncedContainerImagesPage.scsswebpack/scenes/ContentViews/Details/Filters/MatchContentModal/matchContentModal.scsswebpack/scenes/ContentViews/Details/Versions/Compare/CVVersionCompare.scsswebpack/scenes/ContentViews/Details/Versions/ContentViewVersionErrata.scsswebpack/scenes/ContentViews/Publish/cvPublishForm.scsswebpack/scenes/ContentViews/components/EnvironmentPaths/EnvironmentPaths.scsswebpack/scenes/RedHatRepositories/components/RecommendedRepositorySetsToggler.scsswebpack/scenes/RedHatRepositories/index.scsswebpack/scenes/Subscriptions/Manifest/ManageManifestModal.scsswebpack/scenes/Subscriptions/SubscriptionsPage.scsswebpack/scenes/SyncStatus/SyncStatus.scss
💤 Files with no reviewable changes (1)
- webpack/scenes/RedHatRepositories/components/RecommendedRepositorySetsToggler.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
I ran stylelint from theforeman/foreman#10968
And updated Katello to not override everyones UI.
Found this while looking at empty state for Hosts Index page, and saw that when Katello is not present it has
margin-top:100px, butwebpack/scenes/ContentViews/Details/Filters/MatchContentModal/matchContentModal.scssoverrides it.Considerations taken when implementing this change?
The css extra classes were AI added. The spaces were added with
--fixarg when running stylelint.What are the testing steps for this pull request?
Please take a look at the effected pages to make sure the styles still apply.
Summary by CodeRabbit