Fixes #39322 - Extend valid controller list

[adamruzicka]

What are the changes introduced in this pull request?

Previously, the extension overrode whatever Foreman was shipping, which prevented other plugins from applying their own modifications.

Considerations taken when implementing this change?

Following the general pattern where plugins can extend core but shouldn't hard-override it.

What are the testing steps for this pull request?

• Try saving bookmarks for host bootc images, flatpak remotes and flatpak remote repositories
• The tests here and PRT in Add ArfReport to BOOKMARK_ENTITIES_SELECTION for API bookmark coverage SatelliteQE/robottelo#21539 should pass

Also see theforeman/foreman_openscap#610

Summary by CodeRabbit

• Refactor

  • Restructured bookmark validation logic to improve code organization, clarity, and long-term maintainability of the validation system.

• Tests

  • Added comprehensive automated test coverage for bookmark validation across all supported controller types and configurations, ensuring proper validation behavior and error handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0ca4355-2e70-49cb-93ee-35e8bf0d1129

📥 Commits

Reviewing files that changed from the base of the PR and between 4431dd7 and 460de33.

📒 Files selected for processing (2)

• app/lib/katello/concerns/bookmark_controller_validator_extensions.rb
• test/lib/validators/bookmark_controller_validator_extensions_test.rb

---

📝 Walkthrough

Walkthrough

This PR refactors the bookmark controller validator by extracting Katello controller paths into an explicit KATELLO_CONTROLLERS constant and updating valid_controllers_list to extend the parent list. A new test validates bookmarks for all defined controllers.

Changes

Bookmark Controller Validator Refactoring

Layer / File(s)	Summary
KATELLO_CONTROLLERS constant and validation app/lib/katello/concerns/bookmark_controller_validator_extensions.rb, test/lib/validators/bookmark_controller_validator_extensions_test.rb	KATELLO_CONTROLLERS constant is introduced with controller paths, and valid_controllers_list is updated to return super + KATELLO_CONTROLLERS. Test iterates over each controller and validates bookmark creation with FactoryBot.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically describes the main change: extending the valid controller list to work with Katello controllers while following plugin extension patterns.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[adamruzicka]

Robottelo approves SatelliteQE/robottelo#21539 (comment)

[adamruzicka]

An alternative would be iterating over all controllers that include the katello flavor of the autocomplete concern and check those

[jturel]

Tested & works well

[adamruzicka]

And a green button click? :)