Fixes #37859 - Re-drop evr extension in katello#11159
Merged
Merged
Conversation
sjha4
force-pushed
the
drop_evr_again
branch
from
bbc9a51 to
accb31a
Compare
ianballou
approved these changes
Oct 1, 2024
ianballou
reviewed
Oct 3, 2024
Member
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
What do you think about adding an error if the permissions aren't sufficient?
ianballou
approved these changes
Dec 2, 2024
Member
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
Since I don't think my previous comment is important anymore, ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
This brings back the changes from #11087 which were reverted as part of #11103 to stop blocking 4.14.
Considerations taken when implementing this change?
Also pulled in some updates from #11098 which came out of additional reviews on the first katello PR.
What are the testing steps for this pull request?
Same as testing steps for #11087
Check sudo rpm -qa evr
Remove the rpm: sudo rpm -e evr_package_from_above
Run bundle exec rails katello:reset to mimic fresh installs
Test the usual flows with applicability
To test existing systems just delete the evr package and make sure everything continues to work as normal.