Add support for zip archives, extraction paths#139
Open
darcagn wants to merge 1 commit intoKallistiOS:masterfrom
Open
Add support for zip archives, extraction paths#139darcagn wants to merge 1 commit intoKallistiOS:masterfrom
darcagn wants to merge 1 commit intoKallistiOS:masterfrom
Conversation
Member
|
I approve of this and it sounds great, but... I am complete ass at this bash scripty stuff, so I am not qualified to approve of the code review... just cheerleading.... XD |
Member
|
You mentioned in the discords that this is meant to be for supporting FatFs. Could you include that in with this then? Otherwise it's a bit 'well, why should we bother when nothing is using it' and it's very difficult to validate without trying to modify one of the existing ports or creating another new port that would use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it stands, we can only extract tarballs when downloading and unpacking archives -- no ZIP support.
unzipif so; else we usetar xflike we currently do.EXTRACT_DIRoption for port Makefiles to specific the dir to extract to.UNPACK_CMDoption fromconfig.mk. I doubt it was ever used, we depend upontaranyway, we specify it as a dependency, and since scripts are using arguments that are passed totar, it doesn't make much sense to configure this, since arguments are unlikely to work with any other tool.