Guard tar extraction against path traversal in model download - #1175
Merged
stevemessick merged 1 commit intoAug 11, 2026
Merged
Conversation
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing #1163 I read through the rest of the download path and noticed the
tar extraction at line 8554 calls
tarfile.extractall()with nofilter=.zipfilestrips..automatically and the two zip sites here (5449, 10792) getthat for free.
tarfilenever has. A member named../evil.txtwrites onedirectory above the target, silently, without raising.
safe_extract_tar()usesfilter="data"where available, else vets members withrealpathcontainment checks. Detection ishasattr(tarfile, "data_filter"), nota version check .
filter=was backported to 3.11.4 andrequires-python ">=3.11"still admits 3.11.0–3.11.3, where passing it raisesTypeError.Tests cover the helper and the wiring.
Not verified whether Kaggle sanitizes member names server-side. Happy to drop the fallback and require