build: replace catkin/mrt_cmake_modules with standalone CMake and add Python bindings - #1
Draft
huhaohao wants to merge 9 commits into
Draft
build: replace catkin/mrt_cmake_modules with standalone CMake and add Python bindings#1huhaohao wants to merge 9 commits into
huhaohao wants to merge 9 commits into
Conversation
When this project is added with add_subdirectory() alongside a vendored copy of uniform_bspline, find_package() does not see the in-tree target -- it only searches for an installed uniform_bsplineConfig.cmake. The QUIET find therefore fails, FetchContent clones a second copy, and adding it collides with the targets the vendored copy already defined: add_library cannot create target "uniform_bspline" ... already exists Skip the find and its fetch fallback entirely when uniform_bspline::uniform_bspline is already defined. Standalone builds are unaffected: the target does not exist there, so both run as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Build system (
CMakeLists.txt)catkin,mrt_cmake_modules, andAutoDepsuniform_bspline_ceres::uniform_bspline_ceresas a standardINTERFACECMake target with install exportsuniform_bsplineviaFetchContentwhen not found viafind_packageBUILD_PYTHON_BINDINGS,BUILD_TESTS,BUILD_DOCUMENTATIONoptions (allOFFby default)Python bindings (
bindings/python/)uniform_bspline_cereswithSplineFitterandSplinePositionFinder1d1d,1d3d,3d1d,3d2d) at degrees 1–5Python packaging
pyproject.tomlwithscikit-build-corebackend;pip install .works standalonevcpkg.jsonwith optionaltestsandpython-bindingsfeaturesCI (
.github/workflows/ci.yml)Documentation
README.mdrestructured: short Quick Start + separate Usage section