Add a11y, motion, rate limits, and API versioning - #1294
Merged
Conversation
|
@success-OG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1276
closes #1280
closes #1281
closes #1284
PR description
Summary
prefers-reduced-motionsupport.X-RateLimit-*headers, IP + API-key buckets, and a monitoring snapshot./api/v1path routing, version negotiation, deprecation headers, and a versioning policy/discovery endpoint.#1276 Keyboard navigation and accessibility
Keyboard and assistive-tech users can now reach primary UI without a pointer.
#main-contentand#primary-nav, revealed on focus.role="tab"on tabs, labeled brand/nav/pending-count controls,aria-invalid/aria-describedbyon inputs,aria-busyon submit.#1280 Framer Motion animations
Transitions are animated, and they turn off when the user asks for reduced motion.
framer-motion.MotionConfig reducedMotion="user"wraps the app.AnimatePresence).#1281 Rate limiting
API abuse is limited per tier, per IP, and per API key, with visible quotas.
identityRateLimiter.X-RateLimit-Limit,X-RateLimit-Remaining,X-RateLimit-Reset, andRetry-After.GET /admin/rate-limits, Prometheusrate_limit_events_total.#1284 API versioning
Clients pin a contract without breaking when the next version ships.
/api/v1/; preview/api/v2/.req.apiVersionandX-API-Version-Path.X-API-Version,Accept-Version,Accept;version=) still returns 406 for unknown versions.GET /api/versionsdiscovery document.docs/api/VERSIONING.mdandbackend/docs/API_VERSIONING.md.Test plan
cd frontend && npm installthennpm run test:run(skip links, keyboard nav, screen reader, page transition, reduced motion).prefers-reduced-motion: reduce.cd backend && npm test -- rateLimiter.headers versionRouting versionNegotiation.X-RateLimit-*; exceed a tight limiter and expect429+Retry-After.GET /api/v1/vault/summaryhas no deprecation headers;GET /vault/summarydoes;GET /api/versionslists v1/v2; unsupportedAccept-Versionreturns 406.GET /admin/rate-limits(admin API key) returns the snapshot.