Add dark mode, mobile layout, toasts, and query cache - #1289
Merged
Conversation
|
@miss-yusrah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend UX foundations for YieldVault: consistent theming, usable mobile layout, user-facing toasts, and a real data cache.
#1271 Dark mode
frontend/src/styles/theme.css(CSS variables for surfaces, text, accents, toasts). Light mode overrides[data-theme="light"].ThemeProvider+PreferencesProviderpersist the preference (light|dark|system) inlocalStorage(yieldvault-theme), not only the resolved color.prefers-color-scheme(usePrefersColorScheme/subscribeToSystemTheme).index.htmlapplies the saved or OS theme before paint.#1274 Responsive layout
frontend/src/styles/responsive.css(375 / 768 / 1024, 44px hit targets, safe-area insets).nav-mobile-linkrows.accessibility.cssis now imported (coarse-pointer / focus styles).#1278 Toast notifications
ToastProvideris the notification context (success/error/warning/info).NotificationProvider/useNotification.data-theme.#1279 React Query cache
staleTime+placeholderDatakeep previous data while refetching.networkMode: "offlineFirst"so cached data is used offline.yieldvault-query-cache, 24h), skipped in tests.useInvalidateQueries.useVaultMutations/optimisticVaultCache.Test plan
cd frontend && npm installcloses #1271
closes #1274
closes #1278
closes #1279