Skip to content

Conversation

giordano
Copy link
Member

No description provided.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (f588510) to head (a5219bf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files           1        1           
  Lines          33       33           
=======================================
  Hits           32       32           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member Author

giordano commented May 16, 2025

@fingolfin This is so silly, just

permissions:
  contents: write

seems to be enough to clone the repo, all the rest makes it fail. But it didn't create the tag, so I'm still slightly puzzled.

Edit: actually, this still works with all the previous permissions, so I'm not sure this test is reliable.

@fingolfin
Copy link

Yeah I spent quite a bit on time on trying to debug this and in the end did not find a better solution than just removing all. Not saying none exists, just that I couldn't find it :-(

(I did so after I added the "permissions" to half a dozen repos in JuliaCollections then noticed the problem and undid it there... feeling stupid ... :-( )

@giordano giordano mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants