-
Notifications
You must be signed in to change notification settings - Fork 42
Add options for handling [extras]
dependencies
#528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 11 -1
Lines 412 417 +5
=========================================
+ Hits 412 417 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Could we make this experimental for now? That way, we can try it out, and if we don't like the API, we can change it? |
By "experimental", I mean explicitly document that we are allowed to break it in a minor (or even patch) release of CompatHelper. |
I added a note. |
Co-authored-by: Dilum Aluthge <[email protected]>
Ext = ["Bex_jll", "Skix"] | ||
|
||
[extras] | ||
Baz = "ea10d353-3f73-51f8-a26c-33c1cb351aa5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for moving Baz from [deps]
to [extras]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just not creative enough and hence initially only moved around things. Only later I noticed that an additional dependency is needed to cover all cases.
Co-authored-by: Dilum Aluthge <[email protected]>
@DilumAluthge this PR is ready for another round of review 🙂 |
This PR extends #502 based on @DilumAluthge's suggestions in #502 (comment).
I added an option
open_prs_for_extras
that can be set toIfExistingCompatExtras()
(the default),AllExtras()
orNoExtras()
[my gut feeling is that the names could be improved a bit]. WithIfExistingCompatExtras()
, only[extras]
dependencies with existing compat entry are updated; withAllExtras()
, all[extras]
dependencies are updated (also those without existing compat entry); and withNoExtras()
,[extras]
dependencies are not updated.I went with singleton types (basically a type-based enum) because 1) it felt more consistent with the existing
EntryType
and 2) it's not necessary to check whether the provided value is valid (which would be necessary if the API would be based onSymbol
s).Fixes #166. Closes #502.