Skip to content

Use RealDot.realdot for more efficient real(dot(x, y)) #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use RealDot.realdot for more efficient real(dot(x, y)) #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
name = "SpecialFunctions"
uuid = "276daf66-3868-5448-9aa4-cd146d93841b"
version = "1.8.0"
version = "1.9.0"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
IrrationalConstants = "92d709cd-6900-40b7-9082-c6be49f344b6"
LogExpFunctions = "2ab3a3ac-af41-5b50-aa03-7779005ae688"
OpenLibm_jll = "05823500-19ac-5b8b-9628-191a04bc5112"
OpenSpecFun_jll = "efe28fd5-8261-553b-a9e1-b2916fc3738e"
RealDot = "c1ae055f-0cd5-4b69-90a6-9a35b1a98df9"

[compat]
ChainRulesCore = "0.9.44, 0.10, 1"
Expand All @@ -16,6 +17,7 @@ IrrationalConstants = "0.1"
LogExpFunctions = "0.3"
OpenLibm_jll = "0.7, 0.8"
OpenSpecFun_jll = "0.5"
RealDot = "0.1"
julia = "1.3"

[extras]
Expand Down
1 change: 1 addition & 0 deletions src/SpecialFunctions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ using IrrationalConstants:

import ChainRulesCore
import LogExpFunctions
import RealDot

using OpenLibm_jll
using OpenSpecFun_jll
Expand Down
6 changes: 3 additions & 3 deletions src/chainrules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function ChainRulesCore.rrule(::typeof(besselix), ν::Number, x::Number)
function besselix_pullback(ΔΩ)
ν̄ = ChainRulesCore.@not_implemented(BESSEL_ORDER_INFO)
a = (besselix(ν - 1, x) + besselix(ν + 1, x)) / 2
x̄ = project_x(muladd(conj(a), ΔΩ, - sign(real(x)) * real(conj(Ω) * ΔΩ)))
x̄ = project_x(muladd(conj(a), ΔΩ, - sign(real(x)) * RealDot.realdot(Ω, ΔΩ)))
return ChainRulesCore.NoTangent(), ν̄, x̄
end
return Ω, besselix_pullback
Expand Down Expand Up @@ -246,7 +246,7 @@ function ChainRulesCore.rrule(::typeof(besseljx), ν::Number, x::Number)
x̄ = if x isa Real
project_x(a * ΔΩ)
else
project_x(muladd(conj(a), ΔΩ, - sign(imag(x)) * real(conj(Ω) * ΔΩ) * im))
project_x(muladd(conj(a), ΔΩ, - sign(imag(x)) * RealDot.realdot(Ω, ΔΩ) * im))
end
return ChainRulesCore.NoTangent(), ν̄, x̄
end
Expand Down Expand Up @@ -277,7 +277,7 @@ function ChainRulesCore.rrule(::typeof(besselyx), ν::Number, x::Number)
x̄ = if x isa Real
project_x(a * ΔΩ)
else
project_x(muladd(conj(a), ΔΩ, - sign(imag(x)) * real(conj(Ω) * ΔΩ) * im))
project_x(muladd(conj(a), ΔΩ, - sign(imag(x)) * RealDot.realdot(Ω, ΔΩ) * im))
end
return ChainRulesCore.NoTangent(), ν̄, x̄
end
Expand Down