Fix negative info values for NoPivot() on Julia 1.11+ #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 1.11 changed the convention for LU factorization info field when using NoPivot(). Now, when a zero diagonal is encountered during unpivoted LU factorization, the info field should be negative to distinguish it from pivoted factorization failures. This commit updates RecursiveFactorization to match Julia's convention: - In _generic_lufact!, return negative info when Pivot=false and zero diagonal found - In reckernel!, handle negative info values correctly when adjusting offsets Fixes JuliaLinearAlgebra#95 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Only use negative info values for NoPivot() on Julia 1.11 and later. Earlier versions should continue using positive info values. - Added NOPIVOT_NEGATIVE_INFO constant that checks Julia version - Use this constant to conditionally apply negative info values - Ensures backward compatibility with Julia < 1.11 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NoPivot()#95 where tests fail on Julia 1.11+ due to changed conventions for theinfofield withNoPivot()The Problem
Julia 1.11 changed the convention for LU factorization's info field when using
NoPivot(). When a zero diagonal is encountered during unpivoted LU factorization, the info field should now be negative to distinguish it from pivoted factorization failures.Reference: JuliaLang/julia#52957
The Fix
This PR updates two locations in
src/lu.jl:_generic_lufact!: WhenPivot=falseand a zero diagonal is found, return negative info valuereckernel!: Handle negative info values correctly when adjusting offsets for recursive decompositionTest Results
All tests pass after this fix:
Fixes #95
🤖 Generated with Claude Code