Fix QLayout (#16)

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "0.2.5"
+version = "0.2.6"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/factorizations.jl

@@ -26,9 +26,14 @@ function copyto!(dest::AbstractArray, M::Ldiv{<:AbstractQLayout})
 end
 
 materialize!(M::Lmul{LAY}) where LAY<:AbstractQLayout = error("Overload materialize!(::Lmul{$(LAY)})")
-materialize!(M::Rmul{LAY}) where LAY<:AbstractQLayout = error("Overload materialize!(::Lmul{$(LAY)})")
+materialize!(M::Rmul{LAY}) where LAY<:AbstractQLayout = error("Overload materialize!(::Rmul{$(LAY)})")
+
+materialize!(M::Lmul{QLayout}) = LinearAlgebra.lmul!(M.A, M.B)
+
+
 materialize!(M::Ldiv{<:AbstractQLayout}) = materialize!(Lmul(M.A',M.B))
 
+
 _qr(layout, axes, A; kwds...) = Base.invoke(qr, Tuple{AbstractMatrix{eltype(A)}}, A; kwds...)
 _qr(layout, axes, A, pivot::P; kwds...) where P = Base.invoke(qr, Tuple{AbstractMatrix{eltype(A)},P}, A, pivot; kwds...)
 _lu(layout, axes, A; kwds...) = Base.invoke(lu, Tuple{AbstractMatrix{eltype(A)}}, A; kwds...)

src/lmul.jl

@@ -58,8 +58,8 @@ end
     materialize!(Rmul(dest,M.B))
 end
 
-materialize!(M::Lmul) = lmul!(M.A,M.B)
-materialize!(M::Rmul) = rmul!(M.A,M.B)
+materialize!(M::Lmul) = LinearAlgebra.lmul!(M.A,M.B)
+materialize!(M::Rmul) = LinearAlgebra.rmul!(M.A,M.B)
 
 
 

src/triangular.jl

@@ -71,7 +71,7 @@ BLAS.trmm!('L', 'L', 'C', UNIT, one(T), triangulardata(A)', x)
 end
 
 
-materialize!(M::MatLmulMat{<:TriangularLayout}) = lmul!(M.A, M.B)
+materialize!(M::MatLmulMat{<:TriangularLayout}) = LinearAlgebra.lmul!(M.A, M.B)
 
 ###
 # Rmul

test/runtests.jl

@@ -1,6 +1,8 @@
-using ArrayLayouts, Test
+using ArrayLayouts, Random, Test
 import ArrayLayouts: MemoryLayout, @_layoutlmul, triangulardata
 
+Random.seed!(0)
+
 include("test_layouts.jl")
 include("test_muladd.jl")
 include("test_ldiv.jl")
@@ -83,4 +85,12 @@ triangulardata(A::MyUpperTriangular) = triangulardata(A.A)
     @test lmul!(U, copy(B)) ≈ U * B
 
     @test_skip lmul!(U,view(copy(B),collect(1:5),1:5)) ≈ U * B
+end
+
+@testset "AbstractQ" begin
+    Q = qr(randn(5,5)).Q
+    b = randn(5)
+    @test MemoryLayout(Q) isa QLayout
+    @test all(materialize!(Lmul(Q,copy(b))) .=== lmul!(Q,copy(b)))
+    @test all(materialize!(Lmul(Q',copy(b))) .=== lmul!(Q',copy(b)))
 end