AbstractQ Layout (#15)

* Update factorizations.jl

* Update Project.toml

* layoutrmul

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "0.2.4"
+version = "0.2.5"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/factorizations.jl

@@ -1,13 +1,14 @@
-struct QLayout <: MemoryLayout end
+abstract type AbstractQLayout <: MemoryLayout end
+struct QLayout <: AbstractQLayout end
 
 MemoryLayout(::Type{<:AbstractQ}) = QLayout()
 
-transposelayout(::QLayout) = QLayout()
+adjointlayout(::Type, ::AbstractQLayout) = QLayout()
 
 
-copy(M::Lmul{QLayout}) = copyto!(similar(M), M)
+copy(M::Lmul{<:AbstractQLayout}) = copyto!(similar(M), M)
 
-function copyto!(dest::AbstractArray{T}, M::Lmul{QLayout}) where T
+function copyto!(dest::AbstractArray{T}, M::Lmul{<:AbstractQLayout}) where T
     A,B = M.A,M.B
     if size(dest,1) == size(B,1) 
         copyto!(dest, B)
@@ -18,13 +19,15 @@ function copyto!(dest::AbstractArray{T}, M::Lmul{QLayout}) where T
     materialize!(Lmul(A,dest))
 end
 
-function copyto!(dest::AbstractArray, M::Ldiv{QLayout})
+function copyto!(dest::AbstractArray, M::Ldiv{<:AbstractQLayout})
     A,B = M.A,M.B
     copyto!(dest, B)
     materialize!(Ldiv(A,dest))
 end
 
-materialize!(M::Ldiv{QLayout}) = materialize!(Lmul(M.A',M.B))
+materialize!(M::Lmul{LAY}) where LAY<:AbstractQLayout = error("Overload materialize!(::Lmul{$(LAY)})")
+materialize!(M::Rmul{LAY}) where LAY<:AbstractQLayout = error("Overload materialize!(::Lmul{$(LAY)})")
+materialize!(M::Ldiv{<:AbstractQLayout}) = materialize!(Lmul(M.A',M.B))
 
 _qr(layout, axes, A; kwds...) = Base.invoke(qr, Tuple{AbstractMatrix{eltype(A)}}, A; kwds...)
 _qr(layout, axes, A, pivot::P; kwds...) where P = Base.invoke(qr, Tuple{AbstractMatrix{eltype(A)},P}, A, pivot; kwds...)

src/lmul.jl

@@ -79,4 +79,20 @@ macro layoutlmul(Typ)
         ArrayLayouts.@_layoutlmul LowerTriangular{T, <:$Typ{T}} where T
         ArrayLayouts.@_layoutlmul UnitLowerTriangular{T, <:$Typ{T}} where T
     end)
+end
+
+macro _layoutrmul(Typ)
+    esc(quote
+        LinearAlgebra.rmul!(A::AbstractMatrix, B::$Typ) = ArrayLayouts.materialize!(ArrayLayouts.Rmul(A, B))
+        LinearAlgebra.rmul!(A::StridedMatrix, B::$Typ) = ArrayLayouts.materialize!(ArrayLayouts.Rmul(A, B))
+    end)
+end
+
+macro layoutrmul(Typ)
+    esc(quote
+        ArrayLayouts.@_layoutrmul UpperTriangular{T, <:$Typ{T}} where T
+        ArrayLayouts.@_layoutrmul UnitUpperTriangular{T, <:$Typ{T}} where T
+        ArrayLayouts.@_layoutrmul LowerTriangular{T, <:$Typ{T}} where T
+        ArrayLayouts.@_layoutrmul UnitLowerTriangular{T, <:$Typ{T}} where T
+    end)
 end