Include FreeBSD when generating versiondb#948
Merged
Conversation
This splits out the versiondb part of PR 872. This ensures that any updates to versiondb that happen while 872 is in development don't require re-syncing, and it will mean that tests will pass locally. For some reason, versions.json lists the FreeBSD triplet with the suffix 11.1, which does not reflect the version of FreeBSD used for building and has not been supported for a long time. In fact, the current FreeBSD binaries won't work on anything before 13.2. But in order to use versions.json without some special-casing and/or refactoring, we'll just retain the weird suffix.
Member
Author
|
I verified locally that the changes made here work, but I didn't include the output as part of this PR. I figured that we can rerun the versiondb update after this is merged so that everything is in a fully consistent state. |
davidanthoff
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the versiondb part of #872. This ensures that any updates to versiondb that happen while #872 is in development don't require re-syncing, and it will mean that tests will pass locally. (Though the test that failed locally that was related to this mysteriously passed on CI in #872.)
For some reason, versions.json lists the FreeBSD triplet with the suffix 11.1, which does not reflect the version of FreeBSD used for building and has not been supported for a long time, by us or upstream. In fact, the current FreeBSD binaries won't work on anything before 13.2. But in order to use versions.json without some special-casing and/or refactoring, we can just retain the weird suffix.