[JuliaLowering] only hygienic-scope-wrap toplevel if unescaped
#60169
Conversation
mlechu
added
the
compiler:lowering
mlechu
force-pushed
the
jl-moved-escapable-toplevel
branch
from
ad93407 to
2315530
Compare
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Reasoning seems sound 👍
Change looks good to me
| expand_macro(ctx, ex) | ||
| elseif k == K"toplevel" && length(ctx.scope_layer_stack) > 1 | ||
| fix_toplevel_expansion(ctx, ex, current_layer(ctx).mod, | ||
| source_location(LineNumberNode, ex)) |
There was a problem hiding this comment.
This seems to change the LineNumberNode slightly (allows file === nothing), but I guess we don't use this in lowering right now.
Does this affect anything?
There was a problem hiding this comment.
I don't think so, as the file === nothing -> file = :none case above is just for passing line number nodes to buggy macros (buggy assuming file is generally allowed to be anything). We could try always normalizing file to string or symbol everywhere in lowering, but that would be hard to do completely since these things can be values as well.
There was a problem hiding this comment.
Is the argument used though? it seems like macro expansion just drops it right now
There was a problem hiding this comment.
It's used in the expr-macro case
2 participants
Moved from JuliaLang/JuliaLowering.jl#114 with tests added
I didn't originally implement this correctly: toplevel forms coming from macro expansions only need tweaking if we're in some scope layer other than the default one.