[JuliaLowering] get macro name in ctx.world; fix lowering iterator
#60168
+75
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlechu
added
the
compiler:lowering
mlechu
force-pushed
the
jl-iterator-world-age
branch
from
46674f4 to
84f90da
Compare
topolarity
reviewed
Nov 19, 2025
Comment on lines
+74
to
+78
| ctx1 = let c = iter.ctx | ||
| MacroExpansionContext( | ||
| c.graph, c.bindings, c.scope_layers, c.scope_layer_stack, | ||
| c.expr_compat_mode, world) | ||
| end |
Member
There was a problem hiding this comment.
This might be worth a separate helper / constructor
One common pattern is:
MacroExpansionContext(ctx::MacroExpansionContext; graph = ctx.graph, bindings = ctx.bindings, scope_layers = ctx.scope_layers, scope_layer_stack = ctx.scope_layer_stack, expr_compat_mode = ctx.expr_compat_mode, world = ctx.world) = MacroExpansionContext(graph, bindings, scope_layers, scope_layer_stack, expr_compat_mode, world)
ctx1 = MacroExpansionContext(iter.ctx; world = world)
Member
Author
There was a problem hiding this comment.
We should probably just create a brand-new macro context for each step. I don't see why we need a big graph with everything in it, and it might mess with the ctx.scope_layers[1]-is-always-the-base-layer assumption from your fix in #60174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating a macro's name should be done in the same world we pass into lowering and use for expansion. Fix this for all reasonable macro names.
The lowering iterator (currently very cold code only used for module/toplevel expressions that JuliaLowering "controls") also needs to update the expansion world between steps.