Test with julia 1.10 #390
Test with julia 1.10 #390
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 89.89% 89.97% +0.08%
==========================================
Files 7 7
Lines 1316 1317 +1
==========================================
+ Hits 1183 1185 +2
+ Misses 133 132 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fail-fast: false | ||
| matrix: | ||
| version: | ||
| - '1.10' |
There was a problem hiding this comment.
Maybe use
| - '1.10' | |
| - 'lts' |
?
There was a problem hiding this comment.
This is the more standard thing to test against, right? I'd prefer not to hard-code any Julia versions.
There was a problem hiding this comment.
Yes, this pr was me trying to figure out why the test was failing locally but not on CI.
|
@nhz2, this PR: JuliaServices/StructUtils.jl#14, fixes the test failure for 1.10 for me. It's a weird one. I didn't dig in to the code_typed/code_llvm level, but forcing outlining of this code ensures it runs, whereas keeping it inline results in it getting skipped. Issue not present in 1.11/1.12, so must have been a bug in 1.10. |
|
I bisected the fix to JuliaLang/julia@15f7db8 It seems like a known compiler bug in Julia 1.10. |
No description provided.