Skip to content

bump compat for AbstractDifferentiation to 0.6 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bump compat for AbstractDifferentiation to 0.6 #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3dafc7
CompatHelper: bump compat for AbstractDifferentiation to 0.6, (keep e…
Oct 13, 2023
bba63ae
unmark things as broken that were fixed with AD 0.6
oxinabox Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Diffractor"
uuid = "9f5e2b26-1114-432f-b630-d3fe2085c51c"
authors = ["Keno Fischer <[email protected]> and contributors"]
version = "0.2.3"
version = "0.2.4"

[deps]
AbstractDifferentiation = "c29ec348-61ec-40c8-8164-b8c60e9d9f3d"
Expand All @@ -16,7 +16,7 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
StructArrays = "09ab397b-f2b6-538f-b94a-2f83cf4a842a"

[compat]
AbstractDifferentiation = "0.5"
AbstractDifferentiation = "0.6"
ChainRules = "1.44.6"
ChainRulesCore = "1.15.3"
Combinatorics = "1"
Expand Down
6 changes: 3 additions & 3 deletions test/AbstractDifferentiationTests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ include(joinpath(pathof(AbstractDifferentiation), "..", "..", "test", "test_util
@test backend isa AD.AbstractForwardMode

@testset "Derivative" begin #setfield!(::Core.Box, ::Symbol, ::Float64)
@test_broken test_derivatives(backend)
test_derivatives(backend)
end
@testset "Gradient" begin #Diffractor.TangentBundle{1, Float64, Diffractor.TaylorTangent{Tuple{Float64}}}(::Float64, ::Tuple{Float64})
@test_broken test_gradients(backend)
end
@testset "Jacobian" begin #setfield!(::Core.Box, ::Symbol, ::Vector{Float64})
@test_broken test_jacobians(backend)
test_jacobians(backend)
end
@testset "Hessian" begin #setindex!(::ChainRulesCore.ZeroTangent, ::Float64, ::Int64)
@test_broken test_hessians(backend)
Expand All @@ -61,7 +61,7 @@ include(joinpath(pathof(AbstractDifferentiation), "..", "..", "test", "test_util
@test_broken test_lazy_gradients(backend)
end
@testset "Lazy Jacobian" begin #MethodError: no method matching *(::Diffractor.PrimeDerivativeBack{1, Diagonal{Bool, Vector{Bool}}}, ::Vector{Float64})
@test_broken test_lazy_jacobians(backend; vaugmented=true)
test_lazy_jacobians(backend; vaugmented=true)
end
@testset "Lazy Hessian" begin # everything everywhere all at once is broken
@test_broken test_lazy_hessians(backend)
Expand Down