Skip to content

Conversation

@RainerHeintzmann
Copy link
Contributor

As opposed to the previous discussion the correct rule for copysign(y,x) should probably be:

@scalar_rule copysign(y, x) (ifelse(signbit(x)!=signbit(y), -one(y), +one(y)), NoTangent())

. You can also find the arguments there why NoTangent() is preferred over 0.
The testing gets into problems, if too close to zero for x or y, due to the non-continuity of this function.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #502 (8ee5ccc) into master (262be3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          22       22           
  Lines        2356     2357    +1     
=======================================
+ Hits         2312     2313    +1     
  Misses         44       44           
Impacted Files Coverage Δ
src/rulesets/Base/fastmath_able.jl 98.33% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262be3c...8ee5ccc. Read the comment docs.

@oxinabox
Copy link
Member

thanks!

@oxinabox oxinabox merged commit 773039a into JuliaDiff:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants