Fix norm of StaticArrays with non-finite elements #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failures with Julia nightly are because of #1162 |
Contributor
Author
mateuszbaran
approved these changes
May 13, 2023
Collaborator
mateuszbaran
left a comment
mateuszbaran
left a comment
There was a problem hiding this comment.
LGTM. Could you just bump patch version? I will wait a couple of days before merging in case someone has some remarks.
Contributor
Author
Thanks! Sure; done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135 by making the functionality introduced in #975 play nicer with arrays that contain
NaNor(±)Infelements. This removes an unexpected dependence of the return ofnorm()on the ordering of the elements in these cases, and also makes the results consistent with regular Julia arrays.(Thanks to @rmkn85 for the help in tracing the cause of this one)
EDIT: fix typos