Skip to content

Conversation

oscardssmith
Copy link
Member

This arguably should be 2 separate PRs, the first splits the code in this repo into files for better separation of concerns, while the 2nd (and only functional change) adds a new FixedSizeBitArray that is similar to a regular BitArray, but is fixed size, and makes sure that columns don't alias each-other (by giving each column it's own chunk). This slightly complicates indexing, but it makes lots of matrix operations a lot faster since you can broadcast views of the columns with each-other without worrying about columns clobbering each other.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

❌ Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.73%. Comparing base (810c0a0) to head (e00a970).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/FixedSizeBitArray.jl 0.00% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
- Coverage   98.71%   82.73%   -15.98%     
===========================================
  Files           3        4        +1     
  Lines         233      278       +45     
===========================================
  Hits          230      230               
- Misses          3       48       +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nsajko
Copy link
Member

nsajko commented Jan 4, 2025

This arguably should be 2 separate PRs

Why not split it up?

@oscardssmith
Copy link
Member Author

I probably will

@giordano
Copy link
Collaborator

giordano commented Jan 5, 2025

Some tests would be good now 🙂

@oschulz
Copy link

oschulz commented Oct 2, 2025

Closes #155

@giordano giordano linked an issue Oct 2, 2025 that may be closed by this pull request
@giordano giordano changed the title reorganize slightly and add FixedSizeBitArray Add FixedSizeBitArray Oct 2, 2025
@giordano giordano added the enhancement New feature or request label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed-size BitArray?
4 participants