Skip to content

resolve an ambiguity #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

resolve an ambiguity #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78ed98d
Update quasifill.jl
putianyi889 Feb 16, 2024
1c94727
Merge branch 'JuliaApproximation:master' into patch-1
putianyi889 Oct 29, 2024
647bc69
Update test_quasifill.jl
putianyi889 Oct 29, 2024
6cecd2c
Update test_quasifill.jl
putianyi889 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/quasifill.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ sum(x::AbstractQuasiFill) = getindex_value(x)*measure(axes(x,1))
sum(x::QuasiZeros) = getindex_value(x)

# define `sum(::Callable, ::AbstractQuasiFill)` to avoid method ambiguity errors on Julia 1.0
sum(f, x::AbstractQuasiFill) = _sum(f, x)
sum(f::Base.Callable, x::AbstractQuasiFill) = _sum(f, x)
_sum(f, x::AbstractQuasiFill) = measure(x) * f(getindex_value(x))
sum(f, x::AbstractQuasiFill) = _sum(f, x, :)
sum(f::Base.Callable, x::AbstractQuasiFill) = _sum(f, x, :)
_sum(f, x::AbstractQuasiFill, ::Colon) = measure(x) * f(getindex_value(x))


#########
Expand Down
4 changes: 3 additions & 1 deletion test/test_quasifill.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,10 +370,12 @@ import QuasiArrays: AbstractQuasiFill
@test zero(QuasiFill(0.5, ax, ax)) == QuasiZeros(ax,ax)
end

@testset "maximum/minimum/svd/sort" begin
@testset "maximum/minimum/sort/sum" begin
ax = [1,3,4]
@test maximum(QuasiFill(1, ax)) == minimum(QuasiFill(1, ax)) == 1
@test sort(QuasiOnes(ax)) == sort!(QuasiOnes(ax))
@test sum(QuasiFill(1, ax)) == sum(QuasiOnes(ax)) == 3
@test sum(exp, QuasiFill(0, ax)) == sum(exp, QuasiZeros(ax)) == 3
end


Expand Down