test(CustomizeCTA): add TypeScript compiler validation test suite#8082
Conversation
|
@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Great work adding the TypeScript compiler validation test suite for the CustomizeCTA component. It helps ensure the component props are typed correctly. However, the Vercel check is failing. Please resolve the issues and rerun the CI pipeline.
Aamod007
left a comment
There was a problem hiding this comment.
Upon re-evaluation, I realized I previously misinterpreted the Vercel deployment failure as an issue with this PR. The Vercel build failure seems unrelated to the changes introduced here, so I will ignore it moving forward. The rest of the PR looks good, so I'm approving it!
|
🎉 Congratulations @kanishka-2007-tech! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
This PR introduces a dedicated TypeScript compiler validation test suite for the CustomizeCTA component to ensure its public type contract remains stable and protected against future regressions.
Changes Made
Added app/components/CustomizeCTA.type-compiler.test.tsx.
Verified that CustomizeCTA exports a valid function component.
Added compile-time validation for the component's ReactElement return type.
Confirmed the component has no required parameters.
Ensured the component can be invoked without props.
Added a function signature stability check using expectTypeOf.
Fixes #6827
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.