Skip to content

test: add TypeScript compiler validation tests for AdvancedSettingsPanel#7847

Open
kanishka-2007-tech wants to merge 3 commits into
JhaSourav07:mainfrom
kanishka-2007-tech:advance
Open

test: add TypeScript compiler validation tests for AdvancedSettingsPanel#7847
kanishka-2007-tech wants to merge 3 commits into
JhaSourav07:mainfrom
kanishka-2007-tech:advance

Conversation

@kanishka-2007-tech

@kanishka-2007-tech kanishka-2007-tech commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds a dedicated compile-time test suite for AdvancedSettingsPanel to validate TypeScript typings and schema constraints using Vitest's expectTypeOf.

The new test file ensures that the component's public API remains type-safe and helps prevent regressions when prop definitions or callback signatures change.

Changes Made

Added app/customize/components/AdvancedSettingsPanel.type-compiler.test.ts
Added compile-time validation for all component props
Verified callback parameter and return types
Validated enum-based props (ViewMode, DeltaFormat, Language, Timezone)
Ensured optional dimension props (badgeWidth, badgeHeight) correctly accept number | ''
Added schema constraint assertions using expectTypeOf

Fixes #6867

Pillar

  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 9, 2026
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3917.41 KB 3917.41 KB 0 B
Total CSS 325.86 KB 325.86 KB 0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(AdvancedSettingsPanel-type-compiler): verify TypeScript Compiler Validation & Schema Constraints Stability (Variation 10)

1 participant