feat: add Catppuccin Mocha and One Dark themes - #7845
Conversation
|
@AnkitaKumariii is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
4854c47 to
15bd973
Compare
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
|
Ready for review! Could a maintainer please authorize the Vercel deployment? @Aamod007 |
15bd973 to
d953ea4
Compare
you dont need to worry about vercel authorization |
Aamod007
left a comment
There was a problem hiding this comment.
Awesome work adding the Catppuccin Mocha and One Dark themes! Giving users more rich customization options significantly enhances the customization studio experience. The color variables you chose are perfectly aligned with the themes. Note that I am leaving a neutral review because there is currently a repository-level Vercel deployment block preventing full pipeline success, but your feature implementation looks fantastic!
Labels assigned:
- \level:beginner: Adding predefined theme constants.
- \quality:clean: Very clean additions to the theme array.
- \ ype:feature: Adds new customization themes.
|
@Aamod007 change of merge? |
Aamod007
left a comment
There was a problem hiding this comment.
Fantastic additions! Both Catppuccin Mocha and One Dark are extremely popular, elegant themes that look great and meet our WCAG AA contrast standards. Thanks for ensuring the gallery stays updated. Approved!
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for adding Catppuccin Mocha and One Dark themes. Defining these in themes.ts expands the customization options well.
There was a problem hiding this comment.
Pull request overview
Adds two new preset themes (Catppuccin Mocha and One Dark) to CommitPulse’s SVG theme registry and updates the theme documentation and tests to reflect the new options.
Changes:
- Added
catppuccin_mochaandone_darkto the exportedthemesmap (including negative colors). - Updated
THEMES.mdgallery and preview sections to include the two new themes. - Updated theme tests to include the new keys and adjust the expected theme count.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| THEMES.md | Documents the two new theme slugs and adds preview gallery entries. |
| lib/svg/themes.ts | Registers the new theme palettes in the server-side theme registry. |
| lib/svg/themes.test.ts | Updates theme-count expectations and expected theme keys list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Aamod007
left a comment
There was a problem hiding this comment.
Thanks for adding these beautiful themes! Both Catppuccin Mocha and One Dark are fantastic additions to the gallery.
However, there are a couple of issues preventing this from being merged:
- Your branch currently has merge conflicts with the \main\ branch (indicated by the
eeds-rebase\ label). Please rebase your branch on the latest \main\ to resolve these conflicts. - The CI checks are failing on the \Format · Lint · Typecheck · Test\ step because the new code in \lib/svg/themes.ts\ and \lib/svg/themes.test.ts\ is missing indentation. Please run
pm run format\ locally on your machine to fix the formatting before pushing.
Once you've resolved the conflicts and the CI passes, we can get this merged!
Label Justification:
- \level:beginner: Adding new themes to the constants and tests is a great beginner issue.
- \quality:clean: Applied as default pending full review.
- \ ype:feature: Adds new theme presets.
- \mentor:Aamod007: Assigned as required.
|
@JhaSourav07 @Aamod007, All the conflict resolved now you can merge this. |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod007
left a comment
There was a problem hiding this comment.
New commits add the theme definitions, update THEMES.md, and fix mock fetch in EditorPanel tests. The Catppuccin Mocha and One Dark themes look great — the color values are faithful to both original palettes.
CI is failing — please check the logs and push fixes.
Label update: level:intermediate — 8 files with theme definitions, documentation, and test adjustments.
Aamod007
left a comment
There was a problem hiding this comment.
Re-reviewing: the only CI failure was Vercel authorization (not code-related). All code checks pass. The Vercel deploy auth is a repo-level config issue. Approving.
|
@JhaSourav07 All code checks pass ✅. The only CI failure is the Vercel deployment authorization, which requires the maintainer to configure the VERCEL_TOKEN, VERCEL_ORG_ID, and VERCEL_PROJECT_ID secrets in the repo settings. |
|
🎉 Congratulations @AnkitaKumariii! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #7832
Added two highly requested developer themes to the gallery:
Both themes pass WCAG AA contrast standards and provide excellent aesthetics.
Pillar
Visual Preview
Catppuccin Mocha
One Dark
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter. (Note: The README delegates toTHEMES.md, which has been fully updated!)