Fix round() stub: duplicate $mode parameter for PHP 8.4+ #1799
Conversation
The current stub for `round()` in `standard/standard_3.php` defines `$mode` twice, which causes inspections in PhpStorm to report "Function has a parameter whose default value is incompatible with its declared type".
| int|float $num, | ||
| int $precision = 0, | ||
| #[PhpStormStubsElementAvailable(from: '5.3', to: '8.4')] #[LanguageLevelTypeAware(['8.4' => 'RoundingMode|int'], default: 'int')] $mode = 0, | ||
| #[PhpStormStubsElementAvailable(from: '5.3', to: '8.3')] #[LanguageLevelTypeAware(['8.4' => 'RoundingMode|int'], default: 'int')] $mode = 0, |
There was a problem hiding this comment.
This change is incorrect.
You have one $mode defined from 5.3 to 8.4
and one $mode defined from 8.5
It shouldn't overlap.
By changing the 8.4 to 8.3
- There is no mode defined in 8.4
- There is a conflict between PhpStormStubsElementAvailable (from 5.3 to 8.3) and the LanguageLevelTypeAware (8.4) which have no php version in common
There was a problem hiding this comment.
@VincentLanglet Is completely correct. This change is invalid. Speaking about original problem with which causes inspections in PhpStorm to report "Function has a parameter whose default value is incompatible with its declared type". It was caused by previous version of this stub that had only one $mode definition. And the current version of stub aimed to fix exactly this issue. The problem originally reported in ticket https://youtrack.jetbrains.com/issue/WI-82556. Please check if you are using the latest PhpStorm version (2025.2.3)
3 participants
The current stub for
round()instandard/standard_3.phpdefines$modetwice, which causes inspections in PhpStorm to report "Function has a parameter whose default value is incompatible with its declared type".